Change gdrive system tests#66930
Open
Crowiant wants to merge 1 commit into
Open
Conversation
boring-cyborg
Bot
added
area:providers
provider:google
Crowiant
force-pushed
the
change-gdrive-system-tests
branch
from
1104480 to
b7a2739
Compare
phanikumv
reviewed
May 14, 2026
| @@ -28,6 +28,7 @@ | |||
| import logging | |||
| import os | |||
| from datetime import datetime | |||
| from functools import cache | |||
Contributor
There was a problem hiding this comment.
Unused from functools import cache in both example Dags (example_gcs_to_gdrive.py:31, example_gdrive_to_gcs.py:24). Ruff F401 will block this.
phanikumv
reviewed
May 14, 2026
Contributor
There was a problem hiding this comment.
FOLDER_ID = "" left in example_gdrive_to_gcs.py:63 and still passed as folder_id=FOLDER_ID to GoogleDriveFileExistenceSensor (~line 117) and GoogleDriveToGCSOperator (~line 127). With
drive_id now supplied, an empty folder_id is at best confusing — likely should also resolve to the shared-drive ID.
shahar1
reviewed
May 14, 2026
| @@ -88,6 +88,7 @@ class GCSToGoogleDriveOperator(BaseOperator): | |||
| "source_object", | |||
| "destination_object", | |||
| "impersonation_chain", | |||
| "destination_folder_id", | |||
Contributor
There was a problem hiding this comment.
Adding this as template field should be mentioned in the title
Crowiant
force-pushed
the
change-gdrive-system-tests
branch
from
b7a2739 to
44fe181
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.